#8579 & #8614: Migrate mod component form state #8734
Conversation
| availableActivatedModComponentIds: availableInstalledIds, | ||
| isPendingAvailableActivatedModComponents: isPendingInstalledExtensions, | ||
| availableDraftModComponentIds: availableDynamicIds, | ||
| isPendingDraftModComponents: isPendingDynamicExtensions, | ||
| }; | ||
| } | ||
|
|
||
| function migrateFormStateV2(state: BaseFormStateV2): BaseFormStateV3 { |
There was a problem hiding this comment.
The actual redux-persist migrations
Playwright test results
Details
Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
| RegistryId, | ||
| ModComponentFormState[] | ||
| >; | ||
| deletedModComponentFormStatesByModId: Record<RegistryId, BaseFormStateV2[]>; |
There was a problem hiding this comment.
Ensure we're pointing to the previous BaseFormState in the previous EditorState
|
At first glance looking good. A callout on |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8734 +/- ##
=======================================
Coverage 74.24% 74.25%
=======================================
Files 1332 1332
Lines 40817 40828 +11
Branches 7634 7634
=======================================
+ Hits 30306 30315 +9
- Misses 10511 10513 +2 ☔ View full report in Codecov by Sentry. |
| @@ -39,6 +41,7 @@ export const migrations: MigrationManifest = { | |||
| 1: (state) => state, | |||
| 2: (state: EditorStateV1 & PersistedState) => migrateEditorStateV1(state), | |||
| 3: (state: EditorStateV2 & PersistedState) => migrateEditorStateV2(state), | |||
| 4: (state: EditorStateV3 & PersistedState) => migrateEditorStateV3(state), | |||
There was a problem hiding this comment.
Implemented migration here
| @@ -15,4 +15,4 @@ | |||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| */ | |||
|
|
|||
| export const PIPELINE_BLOCKS_FIELD_NAME = "extension.blockPipeline"; | |||
| export const PIPELINE_BRICKS_FIELD_NAME = "modComponent.brickPipeline"; | |||
There was a problem hiding this comment.
I debated going through the code and replacing hardcoded "modComponent.brickPipeline..." strings with joinPathParts(PIPELINE_BRICKS_FIELD_NAME, ...), but decided that could be left for later
…migrate-mod-component-form-state
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
What does this PR do?
Remaining Work
blockPipeline->brickPipelineChecklist
For more information on our expectations for the PR process, see the
code review principles doc